chore: Replace raw HTTP status codes with http.HTTPStatus enums
#1545
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The upcoming changes into graphql-server will make this PR not necessary (since most HTTP server logic will be handled there). I'll keep the PR opened until graphene-django gets updated with the new server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello graphene-django!
This pull request replaces raw HTTP status codes with their corresponding values from the standard library's
http.HTTPStatusenum — as a follow-up to #1487. This improves readability and aligns with modern Python conventions.http.HTTPStatushas been available since Python 3.5, so this change should remain compatible with all currently supported versions of Python and not affect backporting.Thanks for your time and review! 🙌